test_distutils_adoption.py 5.8 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198
  1. import os
  2. import platform
  3. import sys
  4. import textwrap
  5. import pytest
  6. IS_PYPY = '__pypy__' in sys.builtin_module_names
  7. _TEXT_KWARGS = {"text": True, "encoding": "utf-8"} # For subprocess.run
  8. def win_sr(env):
  9. """
  10. On Windows, SYSTEMROOT must be present to avoid
  11. > Fatal Python error: _Py_HashRandomization_Init: failed to
  12. > get random numbers to initialize Python
  13. """
  14. if env and platform.system() == 'Windows':
  15. env['SYSTEMROOT'] = os.environ['SYSTEMROOT']
  16. return env
  17. def find_distutils(venv, imports='distutils', env=None, **kwargs):
  18. py_cmd = 'import {imports}; print(distutils.__file__)'.format(**locals())
  19. cmd = ['python', '-c', py_cmd]
  20. return venv.run(cmd, env=win_sr(env), **_TEXT_KWARGS, **kwargs)
  21. def count_meta_path(venv, env=None):
  22. py_cmd = textwrap.dedent(
  23. """
  24. import sys
  25. is_distutils = lambda finder: finder.__class__.__name__ == "DistutilsMetaFinder"
  26. print(len(list(filter(is_distutils, sys.meta_path))))
  27. """
  28. )
  29. cmd = ['python', '-c', py_cmd]
  30. return int(venv.run(cmd, env=win_sr(env), **_TEXT_KWARGS))
  31. skip_without_stdlib_distutils = pytest.mark.skipif(
  32. sys.version_info >= (3, 12),
  33. reason='stdlib distutils is removed from Python 3.12+',
  34. )
  35. @skip_without_stdlib_distutils
  36. def test_distutils_stdlib(venv):
  37. """
  38. Ensure stdlib distutils is used when appropriate.
  39. """
  40. env = dict(SETUPTOOLS_USE_DISTUTILS='stdlib')
  41. assert venv.name not in find_distutils(venv, env=env).split(os.sep)
  42. assert count_meta_path(venv, env=env) == 0
  43. def test_distutils_local_with_setuptools(venv):
  44. """
  45. Ensure local distutils is used when appropriate.
  46. """
  47. env = dict(SETUPTOOLS_USE_DISTUTILS='local')
  48. loc = find_distutils(venv, imports='setuptools, distutils', env=env)
  49. assert venv.name in loc.split(os.sep)
  50. assert count_meta_path(venv, env=env) <= 1
  51. @pytest.mark.xfail('IS_PYPY', reason='pypy imports distutils on startup')
  52. def test_distutils_local(venv):
  53. """
  54. Even without importing, the setuptools-local copy of distutils is
  55. preferred.
  56. """
  57. env = dict(SETUPTOOLS_USE_DISTUTILS='local')
  58. assert venv.name in find_distutils(venv, env=env).split(os.sep)
  59. assert count_meta_path(venv, env=env) <= 1
  60. def test_pip_import(venv):
  61. """
  62. Ensure pip can be imported.
  63. Regression test for #3002.
  64. """
  65. cmd = ['python', '-c', 'import pip']
  66. venv.run(cmd, **_TEXT_KWARGS)
  67. def test_distutils_has_origin():
  68. """
  69. Distutils module spec should have an origin. #2990.
  70. """
  71. assert __import__('distutils').__spec__.origin
  72. ENSURE_IMPORTS_ARE_NOT_DUPLICATED = r"""
  73. # Depending on the importlib machinery and _distutils_hack, some imports are
  74. # duplicated resulting in different module objects being loaded, which prevents
  75. # patches as shown in #3042.
  76. # This script provides a way of verifying if this duplication is happening.
  77. from distutils import cmd
  78. import distutils.command.sdist as sdist
  79. # import last to prevent caching
  80. from distutils import {imported_module}
  81. for mod in (cmd, sdist):
  82. assert mod.{imported_module} == {imported_module}, (
  83. f"\n{{mod.dir_util}}\n!=\n{{{imported_module}}}"
  84. )
  85. print("success")
  86. """
  87. @pytest.mark.usefixtures("tmpdir_cwd")
  88. @pytest.mark.parametrize(
  89. ('distutils_version', 'imported_module'),
  90. [
  91. pytest.param("stdlib", "dir_util", marks=skip_without_stdlib_distutils),
  92. pytest.param("stdlib", "file_util", marks=skip_without_stdlib_distutils),
  93. pytest.param("stdlib", "archive_util", marks=skip_without_stdlib_distutils),
  94. ("local", "dir_util"),
  95. ("local", "file_util"),
  96. ("local", "archive_util"),
  97. ],
  98. )
  99. def test_modules_are_not_duplicated_on_import(distutils_version, imported_module, venv):
  100. env = dict(SETUPTOOLS_USE_DISTUTILS=distutils_version)
  101. script = ENSURE_IMPORTS_ARE_NOT_DUPLICATED.format(imported_module=imported_module)
  102. cmd = ['python', '-c', script]
  103. output = venv.run(cmd, env=win_sr(env), **_TEXT_KWARGS).strip()
  104. assert output == "success"
  105. ENSURE_LOG_IMPORT_IS_NOT_DUPLICATED = r"""
  106. import types
  107. import distutils.dist as dist
  108. from distutils import log
  109. if isinstance(dist.log, types.ModuleType):
  110. assert dist.log == log, f"\n{dist.log}\n!=\n{log}"
  111. print("success")
  112. """
  113. @pytest.mark.usefixtures("tmpdir_cwd")
  114. @pytest.mark.parametrize(
  115. "distutils_version",
  116. [
  117. "local",
  118. pytest.param("stdlib", marks=skip_without_stdlib_distutils),
  119. ],
  120. )
  121. def test_log_module_is_not_duplicated_on_import(distutils_version, venv):
  122. env = dict(SETUPTOOLS_USE_DISTUTILS=distutils_version)
  123. cmd = ['python', '-c', ENSURE_LOG_IMPORT_IS_NOT_DUPLICATED]
  124. output = venv.run(cmd, env=win_sr(env), **_TEXT_KWARGS).strip()
  125. assert output == "success"
  126. ENSURE_CONSISTENT_ERROR_FROM_MODIFIED_PY = r"""
  127. from setuptools.modified import newer
  128. from {imported_module}.errors import DistutilsError
  129. # Can't use pytest.raises in this context
  130. try:
  131. newer("", "")
  132. except DistutilsError:
  133. print("success")
  134. else:
  135. raise AssertionError("Expected to raise")
  136. """
  137. @pytest.mark.usefixtures("tmpdir_cwd")
  138. @pytest.mark.parametrize(
  139. ('distutils_version', 'imported_module'),
  140. [
  141. ("local", "distutils"),
  142. # Unfortunately we still get ._distutils.errors.DistutilsError with SETUPTOOLS_USE_DISTUTILS=stdlib
  143. # But that's a deprecated use-case we don't mind not fully supporting in newer code
  144. pytest.param(
  145. "stdlib", "setuptools._distutils", marks=skip_without_stdlib_distutils
  146. ),
  147. ],
  148. )
  149. def test_consistent_error_from_modified_py(distutils_version, imported_module, venv):
  150. env = dict(SETUPTOOLS_USE_DISTUTILS=distutils_version)
  151. cmd = [
  152. 'python',
  153. '-c',
  154. ENSURE_CONSISTENT_ERROR_FROM_MODIFIED_PY.format(
  155. imported_module=imported_module
  156. ),
  157. ]
  158. output = venv.run(cmd, env=win_sr(env), **_TEXT_KWARGS).strip()
  159. assert output == "success"